Messages in this thread | | | From | Ingo Oeser <> | Subject | Re: [PATCH] framebuffer: Remove old radeon driver | Date | Sat, 28 Jan 2006 21:06:15 +0100 |
| |
On Saturday 28 January 2006 06:59, Antonino A. Daplas wrote: > The console layer has 5 blanking levels, with FB_BLANK_NORMAL defined > as "soft blank" (or blank the display without turning off display sync > signals) -- a console invention. However, VESA has only 4 levels. > > This can be easily fixed by incrementing the blank value by one if > the request originated from userspace. I'll provide a patch > soon.
May I suggest to hide this implementation detail?
E.g. please provide a macro/function blank_fb2vesa() just for this detail instead of doing magic increments in those drivers.
Many thanks!
Regards
Ingo Oeser
[unhandled content-type:application/pgp-signature] | |