lkml.org 
[lkml]   [2006]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] framebuffer: Remove old radeon driver
Date
On Saturday 28 January 2006 06:59, Antonino A. Daplas wrote:
> The console layer has 5 blanking levels, with FB_BLANK_NORMAL defined
> as "soft blank" (or blank the display without turning off display sync
> signals) -- a console invention. However, VESA has only 4 levels.
>
> This can be easily fixed by incrementing the blank value by one if
> the request originated from userspace. I'll provide a patch
> soon.

May I suggest to hide this implementation detail?

E.g. please provide a macro/function blank_fb2vesa() just
for this detail instead of doing magic increments in those drivers.

Many thanks!


Regards

Ingo Oeser

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-01-28 21:10    [W:0.343 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site