Messages in this thread | | | Date | Fri, 27 Jan 2006 14:54:12 -0800 | From | Andrew Morton <> | Subject | Re: [patch 2/2] fix file counting |
| |
Eric Dumazet <dada1@cosmosbay.com> wrote: > > > This patch changes the file counting by removing the filp_count_lock. > > Instead we use a separate atomic_t, nr_files, for now and all > > accesses to it are through get_nr_files() api. In the sysctl > > handler for nr_files, we populate files_stat.nr_files before returning > > to user. > > > > Counting files as an when they are created and destroyed (as opposed > > to inside slab) allows us to correctly count open files with RCU. > > > > Signed-off-by: Dipankar Sarma <dipankar@in.ibm.com> > > --- > > Well... > > I am using a patch that seems sligthly better : It removes the filp_count_lock > as yours but introduces a percpu variable, and a lazy nr_files . (Its value > can be off with a delta of +/- 16*num_possible_cpus()
Yes, I think that is better. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |