Messages in this thread Patch in this message | | | Date | Fri, 27 Jan 2006 18:43:33 +0100 | Subject | Re: [BUG] debugfs: hard link count wrong | From | (Vincent Hanquez) |
| |
On Thu, Jan 26, 2006 at 11:17:49PM -0800, Greg KH wrote: > I'm running 4.3.0, not 4.2.30. I don't know where it came from either, > gentoo's unstable tree has it, and caused me to download it from > somewhere when I built it :)
looks like all fs that use simple_fill_super got a root inode with i_nlink=1 at the start of day.
I've compared with shmem, the nlink is incremented to 2 by a call to shmem_get_inode, when filling_super.
I've test the following patch with debugfs and securityfs, and its seems to cure the problem.
------
Fix incorrect nlink of root inode for filesystems that use simple_fill_super
Signed-off-by: Vincent Hanquez <vincent@snarc.org>
diff -Naur a/fs/libfs.c a/fs/libfs.c --- a/fs/libfs.c 2006-01-03 03:21:10.000000000 +0000 +++ b/fs/libfs.c 2006-01-27 17:43:31.000000000 +0000 @@ -388,6 +388,7 @@ inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; inode->i_op = &simple_dir_inode_operations; inode->i_fop = &simple_dir_operations; + inode->i_nlink = 2; root = d_alloc_root(inode); if (!root) { iput(inode); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |