Messages in this thread | | | Subject | Re: [PATCH 1/5] stack overflow safe kdump (2.6.16-rc1-i386) - safe_smp_processor_id | From | (Eric W. Biederman) | Date | Wed, 25 Jan 2006 03:23:40 -0700 |
| |
Andrew Morton <akpm@osdl.org> writes:
> It assumes that all x86 SMP machines have APICs. That's untrue of Voyager. > I think we can probably live with this assumption - others would know > better than I.
So looking at the code hard_smp_processor_id is fine. Voyager also implements that.
If we are running UP with an SMP kernel we are fine.
But I think x86_cpu_to_apicid will get us into trouble on Voyager, because I don't think we should compile smpboot.c as it has conflicting simples with voyager_smp.c
Although reading the makefile I don't see how we can avoid compiling them both in SMP mode.
Everything else has a local apic when running SMP so we should be good there.
Eric
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |