Messages in this thread | | | Subject | Re: [PATCHv2] parport: add parallel port support for SGI O2 | From | Arnaud Giersch <> | Date | Wed, 25 Jan 2006 00:33:16 +0100 |
| |
Mardi 24 janvier 2006, vers 00:38:57 (+0100), j'ai écrit:
> I will correct the style.
[...]
> I will add a comment to explain it in the code.
[...]
> I did not realized that. I will try to correct the problem.
An updated version is available at http://arnaud.giersch.free.fr/parport_ip32/parport_ip32-0.6.patch.gz
Since all changes are non-functional ones, I did not want to flood the lists again with the full patch.
Changes are:
* Address comments from Andrew Morton <akpm_at_osdl.org>: - Style: avoid single line "if" and "case" statements. - Turn some printk() into pr_debug1(), so that they only exist in debugging mode. - Add a comment about "volatile". - Add a comment about readsb() and writesb(). * Only define DEBUG_PARPORT_IP32 if it is not already defined. * Remove the CVS $Id$ line.
Arnaud - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |