Messages in this thread | | | Date | Mon, 23 Jan 2006 16:30:37 -0800 (PST) | Subject | Re: [PATCH] sungem: Make PM of PHYs more reliable (#2) | From | "David S. Miller" <> |
| |
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Sun, 22 Jan 2006 14:06:10 +1100
> On my latest laptop, I've had occasional PHY dead on wakeup from > sleep... the PHY would be totally unresponsive even to toggling the hard > reset line until the machine is powered down... Looking closely at the > code, I found some possible issues in the way we setup the MDIO lines > during suspend along with slight divergences from what Darwin does when > resetting it that may explain the problem. That patch change these and > the problem appear to be gone for me at least... I also fixed an mdelay > -> msleep while I was at it to the pmac feature code that is called > when toggling the PHY reset line since sungem doesn't call it in an > atomic context anymore. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applied, thanks Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |