Messages in this thread | | | Date | Mon, 2 Jan 2006 23:03:08 +0100 | From | Antonio Vargas <> | Subject | Re: [patch 00/2] improve .text size on gcc 4.0 and newer compilers |
| |
On 1/2/06, Grant Coady <grant_lkml@dodo.com.au> wrote: > On Mon, 02 Jan 2006 19:49:06 +0100, Arjan van de Ven <arjan@infradead.org> wrote: > > >Maybe the right approach is to start rejecting in reviews new code that > >uses inline inappropriately. (where "inappropriate" sort of is "more > >than 3 lines of C unless there is some constant-optimizes-away trick") > > Well, I can own up to half a dozen inlines in a .c file, CodingStyle > suggests to convert macros to static inline, so I did: > > /* adm9240 internally scales voltage measurements */ > static const u16 nom_mv[] = { 2500, 2700, 3300, 5000, 12000, 2700 }; >
[snip some static inline functons]
> > Are these typical targets for non-inline?
according to the latest flamewars, maybe it would be better to just turn the #defines into static functions instead on static inlines... guess even better would be to just get CodingStyle fixed ASAP ;)
-- Greetz, Antonio Vargas aka winden of network
http://wind.codepixel.com/ windNOenSPAMntw@gmail.com thesameasabove@amigascne.org
Every day, every year you have to work you have to study you have to scene. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |