Messages in this thread Patch in this message | | | Date | Thu, 12 Jan 2006 18:37:46 -0800 | From | Chris Wright <> | Subject | [PATCH 08/17] [PATCH] netlink oops fix due to incorrect error code |
| |
-stable review patch. If anyone has any objections, please let us know. ------------------
Fixed oops after failed netlink socket creation. Wrong parathenses in if() statement caused err to be 1, instead of negative value. Trivial fix, not trivial to find though.
Signed-Off-By: Dmitry Mishin <dim@sw.ru> Signed-Off-By: Kirill Korotaev <dev@openvz.org> Signed-off-by: Chris Wright <chrisw@sous-sol.org> --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.15.y.orig/net/netlink/af_netlink.c +++ linux-2.6.15.y/net/netlink/af_netlink.c @@ -402,7 +402,7 @@ static int netlink_create(struct socket groups = nl_table[protocol].groups; netlink_unlock_table(); - if ((err = __netlink_create(sock, protocol) < 0)) + if ((err = __netlink_create(sock, protocol)) < 0) goto out_module; nlk = nlk_sk(sock->sk); -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |