Messages in this thread | | | Subject | Re: 8250_hp300: initialisation ordering bug | From | Kars de Jong <> | Date | Wed, 07 Sep 2005 22:17:49 +0200 |
| |
On zo, 2005-09-04 at 11:19 +0100, Russell King wrote: > Hi, > > I've noticed that 8250_hp300 is buggy wrt the ordering of hardware > initialisation to the visibility of devices to user space. Namely, > 8250_hp300 does the following: > > ...
> serial8250_register_port() makes the port visible to userspace, so > from that point on it could be opened. However, if it's opened > prior to the remainder of the above completing, we will be missing > interrupts (and what effect does "reset the DCA" have?) > > Surely this hardware fiddling should be completed before we register > the port?
Yes, you are right. I am working on rewriting the driver a bit to use a platform device for the APCI driver, I'll take your bug report into account as well.
On a related note: can I use the "serial8250" platform driver also for non-ISA devices (like my APCI platform device)? The comments in drivers/serial/8250.c suggest it's for ISA devices only, but I don't see a particular reason for not using it for my APCI devices.
Kind regards,
Kars.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |