Messages in this thread | | | Date | Mon, 05 Sep 2005 12:19:25 +0900 (JST) | Subject | Re: x86-cache-pollution-aware-__copy_from_user_ll.patch added to -mm tree | From | Hiro Yoshioka <> |
| |
From: Andrew Morton <akpm@osdl.org>
> Dave Jones <davej@redhat.com> wrote: > > > > On Sun, Sep 04, 2005 at 01:16:00PM -0700, Andrew Morton wrote: > > > unsigned long __copy_to_user_ll(void __user *to, const void *from, unsigned long n) > > > { > > > BUG_ON((long) n < 0); > > > > Ehh? It's unsigned. This will never be true. > > It's cast to long, so it'll trap if we try to copy >=2G. > > It seems a strange thing to check though. Do we really need it?
I don't know. I've just cut&paste the original __copy_from_user_ll()
Regards, Hiro - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |