lkml.org 
[lkml]   [2005]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 01/10] [PATCH] yenta oops fix
    -stable review patch.  If anyone has any objections, please let us know.
    ------------------

    In some cases, especially on modern laptops with a lot of PCI and
    cardbus bridges, we're unable to assign correct secondary/subordinate
    bus numbers to all cardbus bridges due to BIOS limitations unless
    we are using "pci=assign-busses" boot option.
    So some cardbus controllers may not have attached subordinate pci_bus
    structure, and yenta driver must cope with it - just ignore such cardbus
    bridges.

    For example, see https://bugzilla.novell.com/show_bug.cgi?id=113778

    Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
    Signed-off-by: Chris Wright <chrisw@osdl.org>
    ---
    drivers/pcmcia/yenta_socket.c | 13 ++++++++++++-
    1 files changed, 12 insertions(+), 1 deletion(-)

    Index: linux-2.6.13.y/drivers/pcmcia/yenta_socket.c
    ===================================================================
    --- linux-2.6.13.y.orig/drivers/pcmcia/yenta_socket.c
    +++ linux-2.6.13.y/drivers/pcmcia/yenta_socket.c
    @@ -976,7 +976,18 @@ static int __devinit yenta_probe (struct
    {
    struct yenta_socket *socket;
    int ret;
    -
    +
    + /*
    + * If we failed to assign proper bus numbers for this cardbus
    + * controller during PCI probe, its subordinate pci_bus is NULL.
    + * Bail out if so.
    + */
    + if (!dev->subordinate) {
    + printk(KERN_ERR "Yenta: no bus associated with %s! "
    + "(try 'pci=assign-busses')\n", pci_name(dev));
    + return -ENODEV;
    + }
    +
    socket = kmalloc(sizeof(struct yenta_socket), GFP_KERNEL);
    if (!socket)
    return -ENOMEM;
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-30 04:30    [W:6.979 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site