Messages in this thread | | | Date | Thu, 29 Sep 2005 04:36:39 +0200 | From | Jesper Juhl <> | Subject | Re: [RFC][patch 2.6.14-rc2] dell_rbu: Changing packet update mechanism |
| |
On 9/29/05, Abhay_Salunke@dell.com <Abhay_Salunke@dell.com> wrote: > > > -----Original Message----- > From: Jesper Juhl [mailto:jesper.juhl@gmail.com] > Sent: Wednesday, September 28, 2005 7:01 PM > To: Salunke, Abhay > Cc: linux-kernel@vger.kernel.org; akpm@osdl.org > Subject: Re: [RFC][patch 2.6.14-rc2] dell_rbu: Changing packet update > mechanism > > On Friday 23 September 2005 21:40, Abhay Salunke wrote: > > Please ignore earlier patches as there was error submitting it! :-( > > patch below is good... > > > > Ok, I'm being pedantic. So shoot me. > There are a few tiny bits CodingStyle wise that could be better. No big > deal, I'm nitpicking in the extreme here... > > All of this code was ran thourgh Lindent!.
Lindent is not a panacea. It also matters what Documentation/CodingStyle spells out and what is common practice in other parts of the kernel.
> BTW there is a new patch which might have covered your concers. > Got a reference/link?
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |