Messages in this thread | | | Date | Thu, 29 Sep 2005 08:11:10 +1000 | Subject | Re: [RFC][PATCH] identify in_dev_get rcu read-side critical sections | From | Herbert Xu <> |
| |
On Wed, Sep 28, 2005 at 07:51:10AM -0700, Paul E. McKenney wrote: > > The reference-count approach is only guaranteed to work if the kernel > thread that did the reference-count increment is later referencing that > same data element. Otherwise, one has the following possible situation > on DEC Alpha:
You're quite right. Without the rcu_dereference users of in_dev_get() may see pre-initialisation contents of in_dev.
So these barriers are definitely needed.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |