Messages in this thread | | | Date | Tue, 27 Sep 2005 17:23:08 -0400 | From | Jeff Garzik <> | Subject | Re: [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries |
| |
Greg KH wrote: > I don't think you need the change to the comments at the top of the > file.
agreed.
> Also, I thought we wanted to keep all of the pci class ids, why did you > delete them? We should start by removing the pci device and vendor ids > that are not currently used by the kernel, and then slowly move those > ids into the individual drivers, starting with the device ids, and maybe > eventually moving to the vendor ids.
The vendor ids are OBVIOUSLY common constants. The proper place is where they live now: pci_ids.h.
I see little value in moving referenced device ids into individual drivers, as they will make them harder to grep for, as time passes.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |