lkml.org 
[lkml]   [2005]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9] defrag helper functions
>> +void assign_bit(int bit_nr, unsigned long* map, int value)
>
>
> Maybe:
> static inline void assign_bit(int bit_nr, unsigned long* map, int value)
>
> it's short enough

OK. It looks like I'll be sending these again based on the feedback I got,
I'll inline that in the next version. I'd think with it being static that
the compiler would be smart enough to inline it anyway though.

>
>> +static struct page *
>> +fallback_alloc(int alloctype, struct zone *zone, unsigned int order)
>> +{
>> + /* Stub out for seperate review, NULL equates to no fallback*/
>> + return NULL;
>> +
>> +}
>
>
> Maybe "static inline" too.

Except this is only a placeholder for the next patch, where the function
is no longer short. I'm going to keep it not inline.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-27 18:11    [W:0.047 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site