lkml.org 
[lkml]   [2005]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [swsusp] Rework image freeing
    Hi!

    > >
    > > + for_each_zone(zone) {
    > > + for (zone_pfn = 0; zone_pfn < zone->spanned_pages; ++zone_pfn) {
    > > + struct page * page;
    > > + page = pfn_to_page(zone_pfn + zone->zone_start_pfn);
    > > + if (PageNosave(page) && PageNosaveFree(page)) {
    > > + ClearPageNosave(page);
    > > + ClearPageNosaveFree(page);
    > > + free_page((long) page_address(page));
    > > + }
    >
    > There doesn't seem to be much point in converting the pageframe address to
    > a virtual address, then back to a pageframe address. Why not just do
    > put_page() here?

    I do not know what put_page does, and free_page() has some friendly
    BUG_ONs. But if I should just do put_page(page); instead of
    free_page((long) page_address(page)), that is okay with me.

    [Sound of harddrive seeking and CPU fan going up as test kernel
    compiles].

    Pavel

    --
    if you have sharp zaurus hardware you don't need... you know my address
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-21 23:22    [W:5.664 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site