lkml.org 
[lkml]   [2005]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectDont use shortcut when using send_IPI_all in flat mode
    Hi

    This got missed during the previous update for not doing shortcut
    since it introduces race in IPI, when using flat mode.

    The earlier patches addressed send_IPI_allbutself, this one
    take care of the sendall() case as well.

    Andrew: Please consider for -mm

    --
    Cheers,
    Ashok Raj
    - Open Source Technology Center



    Signed-off-by: Ashok Raj <ashok.raj@intel.com>
    --------------------------------------------------------
    arch/x86_64/kernel/genapic_flat.c | 4 ++++
    1 files changed, 4 insertions(+)

    Index: linux-2.6.14-rc1-mm1/arch/x86_64/kernel/genapic_flat.c
    ===================================================================
    --- linux-2.6.14-rc1-mm1.orig/arch/x86_64/kernel/genapic_flat.c
    +++ linux-2.6.14-rc1-mm1/arch/x86_64/kernel/genapic_flat.c
    @@ -94,7 +94,11 @@ static void flat_send_IPI_allbutself(int

    static void flat_send_IPI_all(int vector)
    {
    +#ifndef CONFIG_HOTPLUG_CPU
    __send_IPI_shortcut(APIC_DEST_ALLINC, vector, APIC_DEST_LOGICAL);
    +#else
    + flat_send_IPI_mask(cpu_online_map, vector);
    +#endif
    }

    static int flat_apic_id_registered(void)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-09-21 22:55    [W:2.228 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site