Messages in this thread | | | Date | Wed, 21 Sep 2005 21:48:33 +0200 | From | Frank van Maarseveen <> | Subject | Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss |
| |
On Wed, Sep 21, 2005 at 12:38:08PM -0700, Jay Lan wrote: > Frank van Maarseveen wrote: > >On Wed, Sep 21, 2005 at 08:19:31PM +0100, Hugh Dickins wrote: > > > >>But I think you're right that hiwater_vm is best updated where total_vm > >>is: I'm not sure if it covers all cases completely (I think there's one > >>or two places which don't bother to call __vm_stat_account because they > >>believe it won't change anything), but in principle it would make lots of > >>sense to do it in the __vm_stat_account which typically follows adjusting > >>total_vm, as you did, and if possible nowhere else; rather than adding > >>your inline above. > > > > > >But update_mem_hiwater() is called at various places too, and I guess that > >covers merely the total_vm increase, not rss. > > That is not true. update_mem_hiwater() also updates hiwater_rss.
You're right.
But shouldn't hiwater_rss be updated via a totally different path? When rss changes, total_vm doesn't and vice versa. So maybe there should be _two_ update functions.
-- Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |