Messages in this thread | | | Date | Wed, 21 Sep 2005 04:46:49 +0100 | From | Al Viro <> | Subject | Re: [PATCH 04/12] HPPFS: fix access to ppos and file->f_pos |
| |
On Sun, Sep 18, 2005 at 04:09:51PM +0200, Paolo 'Blaisorblade' Giarrusso wrote: > static ssize_t read_proc(struct file *file, char *buf, ssize_t count, > loff_t *ppos, int is_user) > { > @@ -228,17 +237,21 @@ static ssize_t read_proc(struct file *fi > if (read == NULL) > return -EINVAL; > > + WARN_ON(is_user != (ppos != NULL));
Eww.... Why not pass the right ppos in all cases? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |