Messages in this thread Patch in this message | | | From | Paolo 'Blaisorblade' Giarrusso <> | Subject | [PATCH 5/7] Clearify comment in swapfile.c | Date | Tue, 20 Sep 2005 20:45:50 +0200 |
| |
From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
That comment is unclear enough (since there's no pte_wrprotect) that I "fixed" it, and even Hugh, when rejecting my "fix", agreed on the code being "mystifying". So here's a note on this.
CC: Hugh Dickins <hugh@veritas.com> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> ---
mm/swapfile.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/mm/swapfile.c b/mm/swapfile.c --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -399,9 +399,10 @@ void free_swap_and_cache(swp_entry_t ent /* * Always set the resulting pte to be nowrite (the same as COW pages - * after one process has exited). We don't know just how many PTEs will - * share this swap entry, so be cautious and let do_wp_page work out - * what to do if a write is requested later. + * after one process has exited - so vma->vm_page_prot is already + * write-protected). We don't know just how many PTEs will share this + * swap entry, so be cautious and let do_wp_page work out what to do if + * a write is requested later. * * vma->vm_mm->page_table_lock is held. */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |