Messages in this thread | ![/](/images/icornerl.gif) | | From | Pantelis Antoniou <> | Subject | Re: [PATCH] Au1x00 8250 uart support. | Date | Mon, 19 Sep 2005 23:53:34 +0300 |
| |
On Monday 19 September 2005 23:44, Christoph Hellwig wrote: > > static _INLINE_ unsigned int serial_in(struct uart_8250_port *up, int offset) > > { > > +#ifdef CONFIG_SERIAL_8250_AU1X00 > > + if (up->port.iotype == UPIO_AU) > > + offset = au_io_in_map[offset]; > > +#endif > > All this ifdef stuff is rather messy. Allowing the driver to specity a map > in some structure might make more sense. > >
Sure, I can do that.
But the check for the map existence will take a couple of instructions then, for all architectures. If you're fine with that, it'd be no problem.
Regards
Pantelis - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |