Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: aoe fails on sparc64 | From | Ed L Cashin <> | Date | Mon, 19 Sep 2005 10:24:00 -0400 |
| |
"David S. Miller" <davem@davemloft.net> writes:
> From: Ed L Cashin <ecashin@coraid.com> > Date: Fri, 16 Sep 2005 09:36:51 -0400 > >> I've been working with Jim MacBaine, and he reports that the patch >> below gets rid of the problem. I don't know why. When I test >> le64_to_cpup by itself, it works as expected. > > This patch should fix the bug. > > diff --git a/arch/sparc64/kernel/una_asm.S b/arch/sparc64/kernel/una_asm.S > --- a/arch/sparc64/kernel/una_asm.S > +++ b/arch/sparc64/kernel/una_asm.S
So it's OK to use the "...._to_cpup" macros with unaligned pointers? I'm asking whether ...
1) Passing le64_to_cpup an unaligned pointer is "OK" and within the intended use of the function. I'm having trouble finding whether this is documented somewhere.
2) These new changes to the sparc64 unaligned access fault handling will make it OK to leave the aoe driver the way it is in the mainline kernel.
... > diff --git a/arch/sparc64/kernel/unaligned.c b/arch/sparc64/kernel/unaligned.c
-- Ed L Cashin <ecashin@coraid.com>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |