Messages in this thread | | | Date | Mon, 12 Sep 2005 13:23:33 -0700 | From | Grant Grundler <> | Subject | Re: [patch 2.6.13] swiotlb: BUG() for DMA_NONE in sync_single |
| |
On Mon, Sep 12, 2005 at 03:53:56PM -0400, John W. Linville wrote: > Call BUG() if DMA_NONE is passed-in as direction for sync_single. > > Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Grant Grundler <iod00d@hp.com>
John, Sorry - I didn't realize the tests for DMA_NONE I pointed out were now redundant. Can you respin this patch removing the redundant checks for DMA_NONE as well?
thanks, grant
> --- > > lib/swiotlb.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/swiotlb.c b/lib/swiotlb.c > --- a/lib/swiotlb.c > +++ b/lib/swiotlb.c > @@ -315,13 +315,13 @@ sync_single(struct device *hwdev, char * > case SYNC_FOR_CPU: > if (likely(dir == DMA_FROM_DEVICE || dma == DMA_BIDIRECTIONAL)) > memcpy(buffer, dma_addr, size); > - else if (dir != DMA_TO_DEVICE && dir != DMA_NONE) > + else if (dir != DMA_TO_DEVICE) > BUG(); > break; > case SYNC_FOR_DEVICE: > if (likely(dir == DMA_TO_DEVICE || dma == DMA_BIDIRECTIONAL)) > memcpy(dma_addr, buffer, size); > - else if (dir != DMA_FROM_DEVICE && dir != DMA_NONE) > + else if (dir != DMA_FROM_DEVICE) > BUG(); > break; > default: > -- > John W. Linville > linville@tuxdriver.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |