lkml.org 
[lkml]   [2005]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [another PATCH] Fix crash on boot in kmalloc_node IDE changes
On Thu, Jul 07, 2005 at 09:38:17AM -0700, Linus Torvalds wrote:
>
>
> On Thu, 7 Jul 2005, Christoph Lameter wrote:
> >
> > Here is IMHO the right way to fix this. Test for the hwif != NULL and
> > test for pci_dev != NULL before determining the node number of the pci
> > bus that the device is connected to.
>
> I think this is pretty unreadable.
>
> If you make it use a trivial inline function for the thing, I think that
> would be ok, though.
>
> Complex expressions are bad.

You could just use the previous patch I posted (hint hint...;)

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-07 18:53    [W:0.050 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site