Messages in this thread | | | Date | Wed, 6 Jul 2005 16:35:11 +0200 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] Fix crash on boot in kmalloc_node IDE changes |
| |
On 7/6/05, Andi Kleen <ak@suse.de> wrote: > > drive->hwif check is redundant, please remove it > > It's not. My first version didn't have it but it still crashed. > It's what actually prevents the crash. > I also don't know why, but it's true.
very weird as HWIF(drive) == drive->hwif:
ide_hwif_t *hwif = HWIF(drive);
...
q = blk_init_queue_node(do_ide_request, &ide_lock, pcibus_to_node(drive->hwif->pci_dev->bus)); if (!q) return 1;
...
if (!hwif->rqsize) {
you should OOPS here
Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |