Messages in this thread | | | Date | Sun, 31 Jul 2005 15:49:58 +1000 | Subject | Re: [PATCH] Fix cryptoapi deflate not handling PAGE_SIZE chunks. | From | Herbert Xu <> |
| |
On Sun, Jul 31, 2005 at 03:14:02PM +1000, Nigel Cunningham wrote: > > Yes, Suspend2 if the user selects deflate as their compressor. The > output data will be PAGE_SIZE chunks, but deflate sometimes thinks it > has an extra byte to give us back.
Are you saying that you're feeding it PAGE_SIZE chunks and it's giving you back something bigger than a page? That is expected since the nature of compression in general is that not everything is compressible. Data streams which are not compressible will end up bigger than what you start with.
What would be a bug is if you feed it something that's deflateBound^-1(PAGE_SIZE) bytes long and it spits back something that's longer than a page.
> I agree that it's ugly and don't recall using it when I had gzip support > in an earlier version of Suspend2. Are you thinking there might be a > better way? If so, I can dig out the old (non crypto api) code.
Well if you could give me a snippet of code that actually uses this stuff to compress pages then I might have a better idea of what it's trying to do.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |