Messages in this thread | | | Date | Tue, 26 Jul 2005 22:08:12 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 0/23] reboot-fixes |
| |
Hi!
> The reboot code paths seems to be suffering from 15 years of people > only looking at the code when it breaks. The result is there > are several code paths in which different callers expect different > semantics from the same functions, and a fair amount of imperfect > inline replication of code. > > For a year or more every time I fix one bug in the bug fix reveals yet > another bug. In an attempt to end the cycle of bug fixes revealing > yet more bugs I have generated a series of patches to clean up > the semantics along the reboot path. > > With the callers all agreeing on what to expect from the functions > they call it should at least be possible to kill bugs without > more showing up because of the bug fix. > > My primary approach is to factor sys_reboot into several smaller > functions and provide those functions for the general kernel > consumers instead of the architecture dependent restart and > halt hooks. > > I don't expect this to noticeably fix any bugs along the > main code paths but magic sysrq and several of the more obscure > code paths should work much more reliably.
It looks good to me. Good ammount of cruft really accumulated there...
Pavel -- teflon -- maybe it is a trademark, but it should not be. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |