Messages in this thread Patch in this message | | | Date | Sat, 16 Jul 2005 09:52:16 +0000 | From | Sam Ravnborg <> | Subject | Re: [PATCH] signed char fixes for scripts |
| |
On Fri, Jul 15, 2005 at 10:14:43PM +0000, J.A. Magallon wrote: > > On 07.16, J.A. Magallon wrote: > > > > On 07.15, Andrew Morton wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc3/2.6.13-rc3-mm1/ > > > > > This time I did not break anything... and they shut up gcc4 ;)
Thanks. Can you please resend with proper changelog and signed-off-by. Diff should be done on top of latest -linus preferable. Also this patch seems relative small compared to the others floating around to cure signed warnings in scripts/ Does this really fix all of them or only a subset of the warnings?
I do not have gcc4 present but maybe thats easy - running gentoo?
> --- linux-2.6.12-jam7/scripts/kallsyms.c.orig 2005-07-06 00:16:39.000000000 +0200 > +++ linux-2.6.12-jam7/scripts/kallsyms.c 2005-07-06 00:42:24.000000000 +0200 > @@ -166,9 +166,9 @@ > * move then they may get dropped in pass 2, which breaks the > * kallsyms rules. > */ > - if ((s->addr == _etext && strcmp(s->sym + offset, "_etext")) || > - (s->addr == _einittext && strcmp(s->sym + offset, "_einittext")) || > - (s->addr == _eextratext && strcmp(s->sym + offset, "_eextratext"))) > + if ((s->addr == _etext && strcmp((char*)s->sym + offset, "_etext")) || > + (s->addr == _einittext && strcmp((char*)s->sym + offset, "_einittext")) || > + (s->addr == _eextratext && strcmp((char*)s->sym + offset, "_eextratext"))) > return 0; > } Can we have a local variable so we do not have all the casts in the if condition?
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |