lkml.org 
[lkml]   [2005]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 7/12] s390: fba dasd i/o errors.
Date
On Monday 11 July 2005 19:36, Martin Schwidefsky wrote:
> [patch 7/12] s390: fba dasd i/o errors.
>
> From: Horst Hummel <horst.hummel@de.ibm.com>
>
> The FBA discipline does not use retries for failed requests. A request
> fails after the first unsuccessful start attempt. There are some rare
> conditions (e.g. CIO path recovery) in which the start of an i/o on
> a fba device can fail. A tiny amount of retries is therefore
> reasonable.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
>
> diffstat:
> drivers/s390/block/dasd_fba.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletion(-)
>
> diff -urpN linux-2.6/drivers/s390/block/dasd_fba.c linux-2.6-patched/drivers/s390/block/dasd_fba.c
> --- linux-2.6/drivers/s390/block/dasd_fba.c 2005-06-17 21:48:29.000000000 +0200
> +++ linux-2.6-patched/drivers/s390/block/dasd_fba.c 2005-07-11 17:37:46.000000000 +0200
> @@ -4,7 +4,7 @@
> * Bugreports.to..: <Linux390@de.ibm.com>
> * (C) IBM Corporation, IBM Deutschland Entwicklung GmbH, 1999,2000
> *
> - * $Revision: 1.39 $
> + * $Revision: 1.40 $
> */
>
> #include <linux/config.h>
> @@ -354,6 +354,8 @@ dasd_fba_build_cp(struct dasd_device * d
> }
> cqr->device = device;
> cqr->expires = 5 * 60 * HZ; /* 5 minutes */
> + cqr->retries = 32;

2..4 maybe, but 32? This isn't tiny by any account.

> + cqr->buildclk = get_clock();
> cqr->status = DASD_CQR_FILLED;
> return cqr;
> }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-07-12 12:30    [W:0.056 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site