Messages in this thread | | | Date | Sat, 9 Apr 2005 10:47:50 +0200 | From | Jean Delvare <> | Subject | Re: [2.6 patch] fs/smbfs/request.c: turn NULL dereference into BUG() |
| |
Hi Andrew, all,
> In a case documented as > > We should never be called with any of these states > > BUG() in a case that would later result in a NULL pointer dereference. > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- linux-2.6.12-rc1-mm3-full/fs/smbfs/request.c.old 2005-03-26 13:19:19.000000000 +0100 > +++ linux-2.6.12-rc1-mm3-full/fs/smbfs/request.c 2005-03-26 13:41:30.000000000 +0100 > @@ -786,8 +642,7 @@ int smb_request_recv(struct smb_sb_info > /* We should never be called with any of these states */ > case SMB_RECV_END: > case SMB_RECV_REQUEST: > - server->rstate = SMB_RECV_END; > - break; > + BUG(); > } > > if (result < 0) {
Can you please pick this one for next -mm?
Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |