Messages in this thread | | | Subject | Re: [PATCH] Add Mac mini sound support | From | Benjamin Herrenschmidt <> | Date | Sun, 10 Apr 2005 09:28:32 +1000 |
| |
On Sat, 2005-04-09 at 13:51 +0200, Per Christian Henden wrote: > The patch below adds sound support on the Mac Mini by making a small change to the PowerMac sound card detection code. > > Details: > > Original code: > >From sound/ppc/pmac.c __init snd_pmac_detect(pmac_t *chip) : > > chip->model = PMAC_AWACS; > ... > if (device_is_compatible(sound, "AOAKeylargo")) { > ... > chip->model = PMAC_SNAPPER; > ... > } > > The chip model is first set to AWACS, then because the check above returns true, it gets set to SNAPPER. > Using AWACS gives perfect sound, using SNAPPER gives no sound at all, so it should use AWACS instead. > Note that the mixer still doesn't work. > > My simple patch makes the mentioned check return false on a Mac Mini.
And is not correct. It might appear to work but it is not the right thing to do. There is no AWACS chip in there. There is a fixed function codec controlled by a couple of GPIOs afaik. I'm working on a major rework of the alsa driver that will include support for the mini and the G5s.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |