Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR | Date | Thu, 07 Apr 2005 11:14:24 +0100 |
| |
Hugh Dickins <hugh@veritas.com> wrote:
> > Remove use of FIRST_USER_PGD_NR from sys_mincore: it's inconsistent (no > other syscall refers to it), unnecessary (sys_mincore loops over vmas > further down) and incorrect (misses user addresses in ARM's first pgd).
You should make it use FIRST_USER_ADDRESS instead. This check allows NULL pointers and suchlike to be weeded out before having to take the semaphore.
Also, just because no other syscall refers to such a value doesn't mean that this one shouldn't and that others shouldn't.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |