Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Tue, 5 Apr 2005 09:46:05 -0700 | From | Greg KH <> | Subject | [01/08] Fix Oops with ALSA timer event notification |
| |
-stable review patch. If anyone has any objections, please let us know.
------------------
the patch below fixes the bug of ALSA timer notification, which is used in the recent ALSA dmix plugin.
- fixed Oops in read() - fixed wake-up polls and signals with new events
Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Chris Wright <chrisw@osdl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- linux/sound/core/timer.c 20 Jan 2005 17:37:00 -0000 1.50 +++ linux/sound/core/timer.c 14 Mar 2005 22:07:32 -0000 @@ -1117,7 +1117,8 @@ if (tu->qused >= tu->queue_size) { tu->overrun++; } else { - memcpy(&tu->queue[tu->qtail++], tread, sizeof(*tread)); + memcpy(&tu->tqueue[tu->qtail++], tread, sizeof(*tread)); + tu->qtail %= tu->queue_size; tu->qused++; } } @@ -1140,6 +1141,8 @@ spin_lock(&tu->qlock); snd_timer_user_append_to_tqueue(tu, &r1); spin_unlock(&tu->qlock); + kill_fasync(&tu->fasync, SIGIO, POLL_IN); + wake_up(&tu->qchange_sleep); } static void snd_timer_user_tinterrupt(snd_timer_instance_t *timeri, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |