Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [03/07] I2C: Fix incorrect sysfs file permissions in it87 and via686a drivers | Date | Thu, 28 Apr 2005 00:47:42 -0500 |
| |
On Wednesday 27 April 2005 12:16, Greg KH wrote: > As a side note, wouldn't it make sense to check, when creating sysfs > files, that readable files have a non-NULL show method, and writable > files have a non-NULL store method? I know drivers are not supposed to > do stupid things, but there is already a BUG_ON for several conditions > in sysfs_create_file, so maybe we could add two more?
Checking at creation time is not enough. Even with such check one could change permissions on a sysfs file and set write bit.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |