Messages in this thread | | | Date | Mon, 25 Apr 2005 17:28:57 +0200 | From | Patrick McHardy <> | Subject | Re: Re-routing packets via netfilter (ip_rt_bug) |
| |
Herbert Xu wrote: > You'll still BUG if the destination is multicast/broadcast. I'm also > unsure whether ipt_REJECT isn't susceptible to the same problem. > Luckily ipt_MIRROR is no more :)
ipt_REJECT is fine, ip_route_input() is only used in NF_IP_FORWARD. But you're right about multicast/broadcast still causing problems, I'll have another look.
> What are the issues with getting rid of the ip_route_input path > altogether? > > The only thing we gain over calling ip_route_output is the ability > to set the input device. But even that is just a fake derived from > the source address in a deterministic way. Therefore any effects > achievable through using ip_route_input can also be done by simply > reconfiguring the policy routing table to look at the local source > addresses instead of (or in conjunction with) the input device.
No, ip_route_me_harder() can be called for packets with non-local source. ip_route_output_slow() rejects non-local source addresses, so the only way to use them for policy routing is by using ip_route_input().
Regards Patrick - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |