lkml.org 
[lkml]   [2005]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1b/7] dlm: core locking
David Teigland writes:
>
> The core dlm functions. Processes dlm_lock() and dlm_unlock() requests.

[...]

> +
> +static int is_remote(struct dlm_rsb *r)
> +{
> + DLM_ASSERT(r->res_nodeid >= 0, dlm_print_rsb(r););
> + return r->res_nodeid ? TRUE : FALSE;
> +}

This can be simply

return r->res_nodeid;

> +
> +static int is_master(struct dlm_rsb *r)
> +{
> + return r->res_nodeid ? FALSE : TRUE;
> +}

This duplicates dlm_is_master() for no obvious reason.

> +
> +int dlm_is_master(struct dlm_rsb *r)
> +{
> + return r->res_nodeid ? FALSE : TRUE;
> +}

This can be simply

return !r->res_nodeid;

Nikita.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-25 20:38    [W:6.425 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site