Messages in this thread | | | Date | Tue, 19 Apr 2005 09:53:48 +0200 | From | Gerd Knorr <> | Subject | Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups |
| |
> - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
That's a debug helper function, please don't drop it. #if 0 might be ok, not sure though, the tveeprom module is also used by a out-of-kernel driver (ivtv). Otherwise the patch looks fine to me.
Gerd
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |