Messages in this thread | | | Date | Wed, 20 Apr 2005 04:12:45 +0200 | From | Jörn Engel <> | Subject | Re: [PATCH 1/4] ppc64: rename arch/ppc64/kernel/pSeries_pci.c |
| |
On Wed, 20 April 2005 01:52:56 +0200, Arnd Bergmann wrote: > > - if (buid) { > - ret = rtas_call(ibm_read_pci_config, 4, 2, &returnval, > - addr, buid >> 32, buid & 0xffffffff, size); > - } else { > - ret = rtas_call(read_pci_config, 2, 2, &returnval, addr, size); > - } > - *val = returnval; > - > - if (ret) > - return PCIBIOS_DEVICE_NOT_FOUND;
You might want to be consistent wrt. braces for one-line conditional statements.
Jörn
-- Optimizations always bust things, because all optimizations are, in the long haul, a form of cheating, and cheaters eventually get caught. -- Larry Wall - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |