Messages in this thread | | | Date | Tue, 19 Apr 2005 21:15:41 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH] introduce generic 64bit rotations and i386 asm optimized version |
| |
On Tue, 19 Apr 2005, Denis Vlasenko wrote:
[ Please inline patches, so it's easier to comment on them ]
> +static inline u64 rol64(u64 x,int num) { ^^^ > + if(__builtin_constant_p(num)) > + return constant_rol64(x,num); > + /* Hmmm... shall we do cnt&=63 here? */ ^^^ num?
> + return ((x<<num) | (x>>(64-num))); > +}
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |