Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 17 Apr 2005 19:46:16 +0200 | From | Patrick McHardy <> | Subject | Re: ACPI/HT or Packet Scheduler BUG? |
| |
Herbert Xu wrote: > On Sat, Apr 16, 2005 at 01:06:39PM +0200, Thomas Graf wrote: > >>qdisc_destroy can still be invoked without qdisc_tree_lock via the >>deletion of a class when it calls qdisc_destroy to destroy its >>leaf qdisc. > > Indeed. Fortuantely HTB seems to be safe as it calls sch_tree_lock > which is another name for qdisc_tree_lock. CBQ on the other hand > needs to have a little tweak.
HTB also needs to be fixed. Destruction is usually defered by the refcnt until ->put(), htb_put() doesn't lock the tree. Same for HFSC and CBQ.
Regards Patrick - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |