Messages in this thread | | | Date | Sat, 16 Apr 2005 04:38:52 +0200 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning |
| |
On Fri, Apr 15, 2005 at 08:10:54PM +0400, Alexey Dobriyan wrote: > On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: > > > This patch fixes the following warning: > > > CC drivers/serial/8250_acpi.o > > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': > > drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' > > > --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old > > +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c > > > +#include <linux/config.h> > > drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.
8250_acpi.c #include's <acpi/acpi_bus.h> which requires config.h .
In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include <linux/config.h> to acpi_bus.h is the other possble correct solution for this issue.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |