Messages in this thread | | | Date | Fri, 15 Apr 2005 16:52:50 -0700 | From | Greg KH <> | Subject | Re: [PATCH] tpm: Stop taking over the non-unique lpc bus PCI ID, Also timer, stack and enum fixes |
| |
On Fri, Apr 15, 2005 at 05:06:06PM -0500, Kylene Hall wrote: > This patch is against the 2.6.12-rc2 kernel source. It changes the tpm > drivers from defining a pci driver structure to a format similar to the > drivers/char/watchdog/i8xx_tco driver. This is necessary because the > lpc_bus only has one PCI ID and claiming that ID in the pci driver probe > process prevents other drivers from finding their hardware.
NO! DO NOT use pci_find_device(). It is broken for systems with pci hotplug (which means any pci system). Please use the way the driver currently works, that is correct.
> This patch > also fixes numerous problems that were pointed out with timer > manipulations, large stack objects, lack of enums and defined constants.
Why not split these up into the proper individual patches? Remember, one patch per "change".
> Still lingering: > > How can I receive Hotplug and ACPI events without being a PCI driver?
You can't, so don't.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |