Messages in this thread | | | Date | Wed, 13 Apr 2005 03:35:06 +0100 | From | Al Viro <> | Subject | Re: [2.6 patch] sound/oss/cs46xx.c: fix a check after use |
| |
On Wed, Apr 13, 2005 at 04:17:39AM +0200, Adrian Bunk wrote: > This patch fixes a check after use found by the Coverity checker.
NAK. Please, read the surrounding code. All places that can call that function have form <expression>->amplifier_ctrl(<same expression>,...); so we _can't_ get NULL first argument. The check should be removed - it's not paranoia, it's simple stupidity. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |