Messages in this thread | | | Date | Tue, 12 Apr 2005 17:38:04 -0700 | From | Joel Becker <> | Subject | Re: [PATCH] hangcheck-timer: Update to 0.9.0. |
| |
On Tue, Apr 12, 2005 at 05:18:01PM -0700, Andrew Morton wrote: > It's not very important, but it would be a bit more conventional to use > CONFIG_X86, CONFIG_ARCH_S390, CONFIG_IA64 and CONFIG_PPC64 for those cases > where such an ifdef is to be used.
Well, yeah, silly me.
> Joel Becker <Joel.Becker@oracle.com> wrote: > > +# define TIMER_FREQ 1000000000ULL > > +# define TIMER_FREQ 0xFA240000ULL > > +# define TIMER_FREQ ((unsigned long long)local_cpu_data->itc_freq) > > +# define TIMER_FREQ (HZ*loops_per_jiffy) > > In the above case specifically, no ifdefs should be needed - you can simply > define CONFIG_HANGCHECK_TIMER_FREQ in arch/*/Kconfig.
Kbuild foo help, please. I can't quite figure out how to represent the non-constant values as code in Kbuild. I can represent them as strings, but then they are strings, not code.
Joel
--
Life's Little Instruction Book #452
"Never compromise your integrity."
Joel Becker Senior Member of Technical Staff Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |