Messages in this thread | | | Date | Tue, 12 Apr 2005 23:01:52 +0200 | From | Francois Romieu <> | Subject | Re: [PATCH 1/3] cifs: md5 cleanup - functions |
| |
Steve French <smfrench@austin.rr.com> : [...] > There was a patch suggested a year or so ago to remove the older cifs > md5 implementation and have cifsencrypt.c use the newer Linux crypto > API, but since it made the code considerably more complex it did not > make any sense. The current crypto API seems to be designed for much > more complex usage patterns than cifs needs it for. The key use for this > for CIFS is the following small function (to calculate the packet > signitures on cifs packets in fs/cifs/cifsencrypt.c)
If you have the patches from 10/2003 in mind, they suffered more from poor taste than from cryptoapi imho.
Btw nobody cared about fs/cifs/connect.c::CIFSNTLMSSPNegotiateSessSetup (indentation from Mars + unchecked allocations before dereferences).
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |