Messages in this thread | | | Date | Tue, 12 Apr 2005 14:06:55 +0200 | From | Jens Axboe <> | Subject | Re: [2.6 patch] drivers/block/ll_rw_blk.c: possible cleanups |
| |
On Tue, Apr 12 2005, Adrian Bunk wrote: > On Tue, Apr 12, 2005 at 07:49:57AM +0200, Jens Axboe wrote: > > On Tue, Apr 12 2005, Adrian Bunk wrote: > > > On Mon, Apr 11, 2005 at 08:12:34AM +0200, Jens Axboe wrote: > > > > On Sun, Apr 10 2005, Adrian Bunk wrote: > > > > > This patch contains the following possible cleanups: > > > > > - make needlessly global code static > > > > > - remove the following unused global functions: > > > > > - blkdev_scsi_issue_flush_fn > > > > > > > > Kill the function completely, it is not used anymore. > > > > > > > > > - __blk_attempt_remerge > > > > > > > > Normally I would say leave that since it's part of the API, but lets > > > > just kill it. I don't envision any further users of the remerging > > > > attempts. > > > > > > > > > - remove the following unused EXPORT_SYMBOL's: > > > > > - blk_phys_contig_segment > > > > > - blk_hw_contig_segment > > > > > - blkdev_scsi_issue_flush_fn > > > > > - __blk_attempt_remerge > > > > > > > > > > Please review which of these changes make sense. > > > > > > > > Looks fine to me, thanks. Can you send a new patch that kills > > > > blkdev_scsi_issue_flush_fn()? > > > > > > I have a problem parsing your email. > > > > > > Which parts of my patch are OK and which shouldn't be applied? > > > Or why do you want a separate blkdev_scsi_issue_flush_fn patch? > > > > I have no problems with your patch, I would just like a revised patch > > that removes blkdev_scsi_issue_flush_fn completely instead since it is > > totally unused. It doesn't make sense to remove the export and make it > > static, since it isn't used internally (and never meant to, it's a > > helper function for drivers). > > My patch does already completely remove blkdev_scsi_issue_flush_fn. > > When I say "remove the following unused global functions:", this means > the patch completely removes the function.
Ah, I misread that, missed it in the patch as well apparently. Then I'm fine with the patch.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |