Messages in this thread | | | Subject | Re: 'BUG: scheduling with irqs disabled' when umounting NFS volume | From | Daniel Walker <> | Date | 11 Apr 2005 09:52:53 -0700 |
| |
On Fri, 2005-04-08 at 21:44, Ingo Molnar wrote: > * Daniel Walker <dwalker@mvista.com> wrote: > > > I submitted a fix for this a while ago, I think .. > > interruptible_sleep_on()'s are broken .. > > sleep_on() is a fundamentally broken interface, it only works on UP - > but there it _does_ rely on the behavior your patch removes. (i.e. > disabled interrupts until we hit schedule()) > > the PREEMPT_RT kernel makes the limitations of sleep_on() even more > apparent. The patch only removes the warning, it doesnt remove the race. > To remove the race, sleep_on() usage should be converted to something > else. (e.g. one of the wait_event() variants)
I know they aren't suppose to be used any more. However, there are 100+ of these calls in the kernel right now ..
Daniel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |