Messages in this thread Patch in this message | | | Date | Sat, 2 Apr 2005 04:53:30 +0100 | From | Matthew Wilcox <> | Subject | Re: PCI: fix an oops in some pci devices on hotplug remove when their resources are being freed. |
| |
On Fri, Apr 01, 2005 at 07:31:41PM -0800, Greg KH wrote: > I agree. However, SGI seems to have some majorly <insert expletive here> > hardware and drivers that cause this line to release a already released > resource. See the other part of this patch for the part where this > resource is supposedly freed up.
That one's even more stupid:
+++ b/kernel/resource.c 2005-04-01 15:37:58 -08:00 @@ -505,6 +505,7 @@ *p = res->sibling; write_unlock(&resource_lock); kfree(res); + res = NULL; return; } p = &res->sibling; This pointer is a local variable! Setting it to null right before return cannot possibly affect anything.
> I took the patch as it doesn't hurt anyone, and it gets them off of my > back. But if you so much as think this patch isn't needed, I'll gladly > revert it, as I'm really not trusting any PCI hotplug patches coming out > from them anymore...
I think the problem is that they have a majorly hacked tree they're working from as well as some quite inexperienced people working on it. They need to do more internal peer review ... and clearly I need to start reviewing their patches more carefully.
So yes, please revert this patch. There is no way it can possibly affect anything.
-- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |