Messages in this thread | | | Date | Fri, 1 Apr 2005 14:29:42 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH scsi-misc-2.6 09/13] scsi: in scsi_prep_fn(), remove bogus comments & clean up |
| |
Hello, James.
On Thu, Mar 31, 2005 at 12:02:20PM -0600, James Bottomley wrote: > On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote: > > - * come up when there is a medium error. We have to treat > > - * these two cases differently. We differentiate by looking > > - * at request->cmd, as this tells us the real story. > > + * come up when there is a medium error. > > This comment isn't wrong. That's exactly what this piece of code: > > if (sreq->sr_magic == SCSI_REQ_MAGIC) { > > is all about ... that's how it distinguishes between the two cases. > > The comment is misleading --- what it actually should say is that req- > >special has different contents depending upon the two cases, so > rephrasing it to be more accurate would be helpful.
Yes, it was misleading, even more so with previous REQ_SPECIAL patches. I'll rewrite the comment once we resolve the REQ_SPECIAL issue.
Thanks.
-- tejun
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |