Messages in this thread | | | Subject | Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm | From | Fruhwirth Clemens <> | Date | Wed, 09 Feb 2005 00:53:56 +0100 |
| |
On Tue, 2005-02-08 at 18:30 -0500, James Morris wrote: > On Tue, 8 Feb 2005, Fruhwirth Clemens wrote: > > > I shot out the last patch too quickly. Having reviewed the mapping one > > more time I noticed, that there as the possibility of "off-by-one" > > unmapping, and instead of doing doubtful guesses, if that's the case, I > > added a base pointer to scatter_walk, which is the pointer returned by > > kmap. Exactly this pointer will be unmapped again, so the vaddr > > comparison in crypto_kunmap doesn't have to do any masking. > > You can't call kmap() in softirq context (why was it even trying?):
Why not? What's the alternative, then?
-- Fruhwirth Clemens <clemens@endorphin.org> http://clemens.endorphin.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |